Fix SetFontFace method to be inline with LoadFontFace#76
Fix SetFontFace method to be inline with LoadFontFace#76harture wants to merge 37 commits intofogleman:masterfrom
Conversation
|
I'd like to merge this but I need to be careful with changing API behavior. Thoughts? |
|
No solution for the API but I just want to +1 the fix, I've been bitten by this recently. I was loading each time the font using |
|
Yes this is fixing/unifying the SetFontFace method. I'm also trying to do the same thing as @remeh did with different results. Thus we have a fork at the moment with this PR included and it seems to work fine. However one thing I don't understand is what the hell are these numbers in LoadFontface supposed to mean? What's " * 72 / 96"? 72 of what? and 96 of what? I had a similar issue with font sizing in the past. Working with a different library in a different language but the root cause is the same I think. The issue was that the font description almost never has correct values for width and height of the font. What I had to do is to use glyphs to get a real text size just before "rendering" it. This is significantly slower because I had to basically render the whole text and get a real height after that but it works every time. You can remove these magic numbers doing that completely at the cost of speed tho. |
|
iirc, 72 is Pixels per Inch and 96 is the assumed DPI for any monitor. Though i only know this because of working with C# Winforms & WPF. Winforms assumes everything is in PPI (72px) and WPF uses proper N * (PPI / DPI) This hit me, because i was hosting a winforms control inside WPF and the fontsizes didn't match. |
Update module golang.org/x/image to v0.23.0
Update module golang.org/x/image to v0.24.0
Update module golang.org/x/image to v0.29.0
Update dependency go to v1.24.5
Update module golang.org/x/image to v0.30.0
Update dependency go to v1.24.6
Update module golang.org/x/image to v0.31.0
Update module golang.org/x/image to v0.32.0
Update module golang.org/x/image to v0.33.0
Update dependency go to v1.25.4
Update dependency go to v1.25.5
Update module golang.org/x/image to v0.34.0
Update module golang.org/x/image to v0.35.0
Update dependency go to v1.25.6
Update dependency go to v1.25.7
Update module golang.org/x/image to v0.36.0
Update dependency go to v1.26.0
No description provided.