[Hotfix Main]: [SNAPPY] Custom logic to calculate min_vol quality metric #1793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1788 (#1788) to the
mainbranch.Hey @piotrkluba, please review this hotfix PR created from your original PR.
Note
Medium Risk
Changes default mesh-quality thresholds (
minVol) based on refinement settings, which can alter meshing behavior and outputs for existing Snappy workflows even when users did not explicitly configure this metric.Overview
QualityMetrics.min_pyramid_cell_volume(min_vol) is changed from a fixed default to an optional field: when omitted it now derivesmeshQuality.minVolas1e-10 * (effective_min_spacing^3), while still supporting explicit values andFalse(translated to-1e30).The Snappy translator adds logic to compute
effective_min_spacingby taking the minimum across surface defaults, body/regionmin_spacingandproximity_spacing, edge spacings, and projected volumeUniformRefinements, then snapping it down to the octree spacing series. Golden JSON fixtures and translator tests are updated (including relaxedatol) to match the new computedminVoloutputs.Written by Cursor Bugbot for commit a547edc. This will update automatically on new commits. Configure here.