Skip to content

[FXC-3191] Added support for gravity#1764

Open
NasserFlexCompute wants to merge 15 commits intomainfrom
nasser/gravity
Open

[FXC-3191] Added support for gravity#1764
NasserFlexCompute wants to merge 15 commits intomainfrom
nasser/gravity

Conversation

@NasserFlexCompute
Copy link
Contributor

@NasserFlexCompute NasserFlexCompute commented Feb 3, 2026

Note

Medium Risk
Touches core unit-system/conversion and solver JSON translation paths; while gravity is optional, incorrect scaling or translation could affect solver setup for cases that enable it.

Overview
Adds optional global gravity support to fluid simulations via a new Gravity model (direction + acceleration magnitude) exposed on Fluid and re-exported in flow360.__init__.

Extends the unit system to include an acceleration dimension (schema/exposed units + Flow360 base/conversion scaling using V_ref^2/L_ref) and updates the solver translator to emit a gravityVector in solver JSON when gravity is configured. Includes new unit/translation tests covering default/custom gravity and SI non-dimensionalization.

Written by Cursor Bugbot for commit 4435e08. This will update automatically on new commits. Configure here.

@awccoppFC awccoppFC marked this pull request as ready for review February 11, 2026 16:45
Copilot AI review requested due to automatic review settings February 11, 2026 16:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@awccoppFC awccoppFC marked this pull request as draft February 11, 2026 16:45
@awccoppFC awccoppFC marked this pull request as ready for review February 12, 2026 15:56
@awccoppFC awccoppFC changed the title Added support for gravity [FXC-3191] Added support for gravity Feb 12, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants