Skip to content

Refactor Icons and CupertinoIcons proxies for member caching and iteration #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FeodorFitsner merged 3 commits into from
Jan 22, 2026
Merged

Refactor Icons and CupertinoIcons proxies for member caching and iteration #6055

FeodorFitsner merged 3 commits into from
Jan 22, 2026
+78 −18

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Jan 22, 2026 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Refactor icon proxy classes and bump package version for a new patch release.

New Features:

  • Support iterating over and getting the length of Icons and CupertinoIcons proxies.

Enhancements:

  • Cache material and cupertino icon members in their proxy classes to avoid repeated construction and improve usability.
  • Align icon data class names with their public proxy types for clearer representation.

Build:

  • Change build version script to bump the patch version component instead of the minor version for development builds.
  • Adjust PyPI cleanup script version filter for the current 0.81.0.dev build range.

Documentation:

  • Add 0.80.4 release notes to the main changelog and the Flutter package changelog.

Chores:

  • Bump the Flutter package version to 0.80.4 in packages/flet/pubspec.yaml.

@FeodorFitsner
Refactor icon proxies for member caching and iteration
de24dd2 
Introduced member caching in _CupertinoIconsProxy and _IconsProxy to avoid duplicate icon instances and improve attribute access. Added __iter__ and __len__ methods for both proxies to support iteration and length queries. Also set __name__ and __qualname__ for icon data classes to improve introspection.
@FeodorFitsner
Update build version script to increment patch version
959f9f6 
The script now increments the patch version instead of the minor version when updating the package version. This ensures versioning follows the semantic versioning convention more closely.
@FeodorFitsner
Bump Flet to 0.80.4 and update Flutter to 3.38.7
8aa7e41 
Updated Flet package version to 0.80.4 and aligned Flutter version to 3.38.7. Changelogs updated to reflect refactoring of icon proxies and Flutter version bump. Adjusted PyPI cleanup script to match new versioning.
@FeodorFitsner FeodorFitsner merged commit 6609d70 into main Jan 22, 2026
39 of 43 checks passed
@FeodorFitsner FeodorFitsner deleted the minor-version-increment branch January 22, 2026 23:41
sourcery-ai[bot]
sourcery-ai bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FeodorFitsner