fix(campaign): consistent seeds for builtin scenarios #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handling - Use base_seed for builtin scenarios in both setup and spam phases to ensure agent addresses match (fixes token transfer failures) - Propagate errors from stage execution instead of silently dropping them - Set redeploy=false in spam phase since setup already handles it - Add unit test for create_spam_cli_args behavior
scharissis
force-pushed
the
sc/campaign-seed-fixes
branch
from
f6659b9 to
a3abe1a
Compare
Contributor
Author
|
A lot of this is in #419, so I'll open a new PR after that is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
campaign runs weren't performing the same way as regular spam runs
Benchmarking
PR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crate