Open
Conversation
gir-bot
added
S: needs-review
Owner
|
@ba-tno thanks for this pull! I'm wondering if it would be useful to make the setting a list and prompt the user for the domain if the setting provides more than one. There may be reasons to use one domain for certain files and another for other files. This is more a question as I'm just thinking about usefulness. |
Author
|
Sorry, I see now that I botched it by calling |
Owner
|
As things have gone silent on this, I may just end up coming back and refactoring this to address related issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (partially) closes issues #44 . I have only a Gitlab custom domain to test with, so that's why I cannot provide a similar change for the Github part.