fix(checker): correct variadic method arg type #889
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking arguments for variadic methods, the index passed to
InElem used "fnNumIn-1", but fnNumIn had already been decremented
to exclude the receiver. This caused InElem to access the receiver
type (index 0) instead of the variadic parameter type, causing a
type error ("cannot use string as argument").
Add "fnInOffset" to the index calculation to correctly reference the
variadic parameter. Regression tests included.
Signed-off-by: Ville Vesilehto <[email protected]>
thevilledev
force-pushed
the
fix/issue-888
branch
from
32d7e0e to
6e63333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking arguments for variadic methods, the index passed to InElem used "fnNumIn-1", but fnNumIn had already been decremented to exclude the receiver. This caused InElem to access the receiver type (index 0) instead of the variadic parameter type, causing a type error ("cannot use string as argument").
Add "fnInOffset" to the index calculation to correctly reference the variadic parameter. Regression tests included.
Fixes #888.