-
-
Notifications
You must be signed in to change notification settings - Fork 531
Update supported versions of Ruby #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kotp
commented
Dec 13, 2025
- description in README
- version for test in CI
|
The impetus was reviewing someone new to Ruby that was using Ruby 2.6 the other day. |
|
Would it be possible to update the track to Ruby 3.4? thinking Ruby 4.0 should be released quite soon |
8699bea to
3e7f7a8
Compare
https://www.ruby-lang.org/en/downloads/branches/ for reference on EOL schedule. |
|
Yes I know that 3.3 is supported for a while longer, but thinking most people likely uses the latest version would it be neat to not be super far behind the latest, thinking breaking changes can be introduced as we can see by the ci failing. |
|
But I still think testing 3.3 makes sense, it just that I think all the tooling and the "main" version should be brought to 3.4 |
We can avoid deprecated and dropped syntax and test for 3.4, knowing that (some) students will be using prior versions, though. We could update it to 3.3 though, knowing that we have a end of life coming up, and moving it up at that time, though. I did conscientiously say "want" rather than "need" to indicate the version of 3.4, since it should not be a necessity currently, but an indication that joy will be more likely had with the newer version. So ruby-version: [3.3, 3.4]While leaving the documentation as it is changed here. What do you think? |
3e7f7a8 to
7e07e9d
Compare
|
The currently failing test is "normal", though undesirable. |
4f9108e to
c13c5f8
Compare
Yes I think that makes sense |
- description in README - version for test in CI
c13c5f8 to
8b5285f
Compare
meatball133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The currently failing test is "normal", though undesirable.
I am a bit afraid if that tests fails all the time thinking it is an exercise test though
Absolutely this, but looking at using minitest-allow to not have CI fail because of the current "Ractors is experimental" and the Ruby 3.4 consistent failing, while 3.3 does pass (usually). We would still get the report of the failures for 3.4, while not failing CI. |