Allow setting DateInput default as start or end#3213
Open
scottnoidea wants to merge 4 commits intoevidence-dev:mainfrom
Open
Allow setting DateInput default as start or end#3213scottnoidea wants to merge 4 commits intoevidence-dev:mainfrom
scottnoidea wants to merge 4 commits intoevidence-dev:mainfrom
Conversation
scottnoidea
had a problem deploying
to
Approval required to run action on external PR
GitHub Actions
Failure
scottnoidea
had a problem deploying
to
Approval required to run action on external PR
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a defaultInput prop to the DateInput component, allowing the default selected date to be specified as the start or end of the range. Current behaviour is the start of the range.
This addresses my use case of having a Daily Report page (single date only), with the user able to pick from a range of dates to see the report for that day. I want the default to be the latest date in the query, rather than the first date as is the current behaviour.
This is my first contrib - happy for any feedback on this, thanks.
Checklist