refactor(translator): move into src layout and use uv properly#213
Merged
crankynetman merged 10 commits intomainfrom Feb 27, 2026
Merged
refactor(translator): move into src layout and use uv properly#213crankynetman merged 10 commits intomainfrom
crankynetman merged 10 commits intomainfrom
Conversation
|
Pytest Celery Scheduler Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 127270c |
|
Django Pytest/Behave Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against 127270c |
samoehlert
reviewed
Feb 27, 2026
.../0035_rename_historicalactiontype_history_date_id_route_manag_history_ee6aeb_idx_and_more.py
Show resolved
Hide resolved
samoehlert
approved these changes
Feb 27, 2026
Collaborator
samoehlert
left a comment
There was a problem hiding this comment.
looks great to me! consistency and getting away from the wild wild west is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now translator is actually a proper python package. We could publish it in pypy if we were so inclined, but for now, at least it's using uv workspaces and actually is setup to not be so intermingled with scram-django. I also updated scheduler to now use the root lockfile so that we can use one lockfile to rule them all. We also have a pre-commit step to check for an out of date lockfile to make sure we don't change pyproject but forget to update the lock. Having the lock file committed allows us to have our builds actually be reproducible, which is nice.
Also updates django-simple-history as
pkg_resourcesseems to have been broken and 3.4+ removes that dependency (and is still compatible with django 4.2)