Skip to content

Conversation

@ackerlar
Copy link
Collaborator

as I understand, these recom/wiso coupling fields for oasis are not used/not working with the latest awiesm2 version anymore

@ackerlar ackerlar requested review from a270105 and mandresm February 17, 2025 17:02
@ackerlar ackerlar self-assigned this Feb 17, 2025
Copy link
Collaborator

@a270105 a270105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we still need to keep this part:

choose_general.with_recom: True: # Set fesom.with_recom: true when general.with_recom: true with_recom: true

Since some namelist changes will be done in the fesom yaml file if fesom.with-recom is TRUE. I guess that the merge by Martin does not affect this.

If the merge was already done, L269-L277 shoul be removed and the wiso_fields in L450, as well. But Miguel should confirm if the merge is completed.

@ackerlar
Copy link
Collaborator Author

I think that we still need to keep this part:

choose_general.with_recom: True: # Set fesom.with_recom: true when general.with_recom: true with_recom: true

Since some namelist changes will be done in the fesom yaml file if fesom.with-recom is TRUE. I guess that the merge by Martin does not affect this.

If the merge was already done, L269-L277 shoul be removed and the wiso_fields in L450, as well. But Miguel should confirm if the merge is completed.

Thanks @a270105 ! I updated the branch. Could you have another look?

@a270105 a270105 self-requested a review February 18, 2025 15:19
@ackerlar
Copy link
Collaborator Author

can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants