-
Notifications
You must be signed in to change notification settings - Fork 17
Batch System #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cleanup/main
Are you sure you want to change the base?
Batch System #1266
Conversation
This converts known batch systems to a dictionary, where there keys are names of the batch systems and the values are the classes (to be constructed).
Removes unneeded variables in get_run_filename
Includes basic documentation for some of the simpler methods.
mandresm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pgierz,
In principle, I don't see any problem with this PR. Can you run esm_tests in Levante with it and in Aleph (pbs)?
If you find any issues with esm_tests (you'll surely find some runs that fail) please let me know, we can have a meeting about it and go over the problems you may find.
|
Note that the target for this branch is to go into "cleanup/main", where I will gather various cleanup activities. For Levante, esm_tests looks fine for compiling only: I unfortunately don't have a testing account on Aleph to check there, but I don't forsee any problems. |
|
Something is very strange with the compute jobs, as now all of the actual |
Cleanup code in batch_system.py