Skip to content

Conversation

@pgierz
Copy link
Member

@pgierz pgierz commented Jan 7, 2025

Cleanup code in batch_system.py

  • better class name

pgierz added 5 commits January 7, 2025 13:25
This converts known batch systems to a dictionary, where there keys are
names of the batch systems and the values are the classes (to be
constructed).
Removes unneeded variables in get_run_filename
Includes basic documentation for some of the simpler methods.
Copy link
Contributor

@mandresm mandresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pgierz,

In principle, I don't see any problem with this PR. Can you run esm_tests in Levante with it and in Aleph (pbs)?

If you find any issues with esm_tests (you'll surely find some runs that fail) please let me know, we can have a meeting about it and go over the problems you may find.

@pgierz
Copy link
Member Author

pgierz commented Jan 15, 2025

Note that the target for this branch is to go into "cleanup/main", where I will gather various cleanup activities.

For Levante, esm_tests looks fine for compiling only:

COMPILING (5.3%) awiesm-2.1
                Directory already exists, skipping
                'bin/fesom.x' does not exist!
                'bin/echam6' does not exist!
                'comp/awiesm/awiesm-2.1//comp-oasis3mct-2.8-paleodyn_script.sh' files are identical
                'comp/awiesm/awiesm-2.1//comp-echam-6.3.05p2-awiesm-2.1_script.sh' files are identical
                'comp/awiesm/awiesm-2.1//comp-fesom-2.1-awiesm-2.1_script.sh' files are identical
                Success!

        COMPILING (10.5%) awiesm-2.1
                Directory already exists, skipping
                'bin/fesom.x' does not exist!
                'bin/echam6' does not exist!
                'comp/awiesm/awiesm-2.1//comp-oasis3mct-2.8-paleodyn_script.sh' files are identical
                'comp/awiesm/awiesm-2.1//comp-echam-6.3.05p2-awiesm-2.1_script.sh' files are identical
                'comp/awiesm/awiesm-2.1//comp-fesom-2.1-awiesm-2.1_script.sh' files are identical
                Success!
                
[...truncated...]

I unfortunately don't have a testing account on Aleph to check there, but I don't forsee any problems.

@pgierz
Copy link
Member Author

pgierz commented Jan 15, 2025

Something is very strange with the compute jobs, as now all of the actual srun elements are missing from the generated batch scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants