feat: add temp package to preferred manifest#453
Open
gameroman wants to merge 2 commits intoes-tooling:mainfrom
Open
feat: add temp package to preferred manifest#453gameroman wants to merge 2 commits intoes-tooling:mainfrom
temp package to preferred manifest#453gameroman wants to merge 2 commits intoes-tooling:mainfrom
Conversation
Contributor
|
given its the same replacements as tempy, we should probably just have one document. do not update the title of the tempy doc, just add a description before the replacements list like "creating temporary files and directories can now be achieved natively in modern engines, making libraries like tempy redundant.". |
Contributor
Author
|
Should I then instead of diffs make it examples without diffs or should I keep the diffs for |
Contributor
|
either works. whichever you think is most helpful. in this case i dont have a preference since a diff will still be helpful, but so will a plain usage example. sorry for the non-answer 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339