Fix differences between openapi spec and implementation.#6517
Merged
michel-laterman merged 2 commits intoelastic:mainfrom Mar 6, 2026
Merged
Fix differences between openapi spec and implementation.#6517michel-laterman merged 2 commits intoelastic:mainfrom
michel-laterman merged 2 commits intoelastic:mainfrom
Conversation
Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400).
michel-laterman
added
Team:Elastic-Agent-Control-Plane
michel-laterman
changed the title
ycombinator
reviewed
Mar 6, 2026
changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml
Outdated
Show resolved
Hide resolved
ycombinator
previously approved these changes
Mar 6, 2026
Contributor
ycombinator
left a comment
ycombinator
left a comment
There was a problem hiding this comment.
Just a typo in the CHANGELOG. Otherwise, LGTM. Thanks for addressing these inconsistencies!
…pec.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
ycombinator
approved these changes
Mar 6, 2026
Contributor
|
@Mergifyio backport 8.19 9.2 9.3 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Fix differnces between openapi spec and implementation. Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400). * Update changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 8005534)
1 task
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Fix differnces between openapi spec and implementation. Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400). * Update changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 8005534)
1 task
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Fix differnces between openapi spec and implementation. Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400). * Update changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 8005534)
1 task
michel-laterman
added a commit
that referenced
this pull request
Mar 6, 2026
* Fix differnces between openapi spec and implementation. Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400). * Update changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml --------- (cherry picked from commit 8005534) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
michel-laterman
added a commit
that referenced
this pull request
Mar 6, 2026
* Fix differnces between openapi spec and implementation. Fix spec so that it more accuratly describes the implenetation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400). * Update changelog/fragments/1772755112-Fix-innacuracies-with-openapi-spec.yaml --------- (cherry picked from commit 8005534) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
open api spec is missing some error responses.
How does this PR solve the problem?
Fix spec so that it more accurately describes the implantation. Fixes include using status code 429 for too many requests (instead of 428) and status code 413 for request size too large (instead of 400).
Note that the only effective code change included is fixing a typo in error.go.
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool