Draft
Conversation
The test previously referenced ErrOpAMPDisabled and handleOpAMP which no longer exist. The feature flag check now happens at route registration time, so test the Enabled() method directly instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Wire up pathToOperation to recognize /v1/opamp and add the opamp case to the limiter middleware. Also apply the limiter middleware to the OpAMP route handler in server.go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This pull request does not have a backport label. Could you fix it @juliaElastic? 🙏
|
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Contributor
🔍 Preview links for changed docs |
10 tasks
Contributor
|
This pull request is now in conflicts. Could you fix it @juliaElastic? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Map data from OpAMP AgentToServer message to Agent fields in
.fleet-agentsDepends on #6270 being merged first, will reopen this PR after that.
Data mapping changes are in this commit: 359d1af#diff-8eae4f76576728f1316ae744b620c2dac1f0ea3964426990df7329dcb9fff745
How does this PR solve the problem?
Add OpAMP message fields to Agent document:
How to test this PR locally
Follow instructions in https://github.com/ycombinator/fleet-server/blob/d9271fa723bf189f16c086559626aad09315637a/docs/opamp.md
Download and extract otel collector, e.g.:
Create otel config to include system fields and internal telemetry, e.g.
otel-opamp.yaml:Create API keys and start otel collector:
Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
Relates https://github.com/elastic/ingest-dev/issues/6982