Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @gxkl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 本次拉取请求旨在初始化一个名为 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying egg with
|
| Latest commit: |
c40e585
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64d2cfc4.egg-cci.pages.dev |
| Branch Preview URL: | https://docs-skills.egg-cci.pages.dev |
Deploying egg-v3 with
|
| Latest commit: |
c40e585
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15c69ad6.egg-v3.pages.dev |
| Branch Preview URL: | https://docs-skills.egg-v3.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request initializes the documentation for @eggjs/skills, adding several well-structured markdown files that cover core concepts, controllers, and decision guides. The documentation is a great start. I've identified a few typos in the markdown files and a potentially incorrect Node.js version requirement in package.json that should be addressed.
| "dependencies": {}, | ||
| "devDependencies": {}, | ||
| "engines": { | ||
| "node": ">=22.18.0" |
There was a problem hiding this comment.
The required Node.js version >=22.18.0 seems overly restrictive and is likely a typo. Node.js 22 is very recent, and a minor version of 18 does not exist. Other documentation in the project suggests a minimum version of Node.js 18. I recommend changing this to a more common and reasonable requirement, such as >=18.0.0.
| "node": ">=22.18.0" | |
| "node": ">=18.0.0" |
packages/skills/controller/SKILL.md
Outdated
|
|
||
| 2. 定时任务，可以使用 Schedule，参考 `references/schedule.md` | ||
|
|
||
| 3. AI集成 MCP，可以使用 MCPController，参考 `refercens/mcp-controller.md` |
There was a problem hiding this comment.
There's a typo in the file path. refercens should be references.
| 3. AI集成 MCP，可以使用 MCPController，参考 `refercens/mcp-controller.md` | |
| 3. AI集成 MCP，可以使用 MCPController，参考 `references/mcp-controller.md` |
| ### HTTPController | ||
| - **装饰器**：`@HTTPController`、`@HTTPMethod` | ||
| - **参数**：`@HTTPParam`、`@HTTPQuery`、`@HTTPBody`、`@HTTPHeaders`、`@Cookies`、`@Request`、`@Context` | ||
| - **详细文档**：`references/httpcontroller.md` |
There was a problem hiding this comment.
There's a typo in the file path. httpcontroller.md should be http-controller.md to be consistent with other links in this file and the actual filename.
| - **详细文档**：`references/httpcontroller.md` | |
| - **详细文档**：`references/http-controller.md` |
| | 用户意图 | 关键词 | 使用技能 | | ||
| |---------|--------|---------| | ||
| | Module architecture | module、workspace、organization | @eggjs/skills-core | | ||
| | Object lifecycle | singleton、context、lifecycle | @eggjs/skills--core | |
There was a problem hiding this comment.
There's a typo in the skill name. @eggjs/skills--core should be @eggjs/skills-core with a single hyphen to be consistent with the rest of the document.
| | Object lifecycle | singleton、context、lifecycle | @eggjs/skills--core | | |
| | Object lifecycle | singleton、context、lifecycle | @eggjs/skills-core | |
|
|
||
| ## 技能交互 | ||
|
|
||
| 本技能（`@eggjs/skills-tegg`）应该： |
There was a problem hiding this comment.
The skill name @eggjs/skills-tegg seems inconsistent. Given the file path packages/skills/egg/SKILL.md and the frontmatter name egg, it should probably be @eggjs/skills-egg to align with other skill naming conventions like @eggjs/skills-core and @eggjs/skills-controller.
| 本技能（`@eggjs/skills-tegg`）应该： | |
| 本技能（`@eggjs/skills-egg`）应该： |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5783 +/- ##
==========================================
+ Coverage 87.57% 87.60% +0.02%
==========================================
Files 563 562 -1
Lines 10940 10923 -17
Branches 1242 1236 -6
==========================================
- Hits 9581 9569 -12
+ Misses 1275 1270 -5
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…es (#5786) - Add references/mcp-controller.md with common errors, file conventions, scenario-based decision tree, and end-to-end examples - Update CLAUDE.md with skill writing methodology: prioritize gap-filling over doc reformatting, interview maintainers for undocumented knowledge - Fix typo in controller SKILL.md (refercens -> references) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2 participants
No description provided.