Skip to content

feat: add pushToTop and pushToTopOnce#173

Merged
thetutlage merged 3 commits intoedge-js:6.xfrom
bnb:bnb/add-pushToTop-and-pushToTopOnce
Feb 23, 2026
Merged

feat: add pushToTop and pushToTopOnce#173
thetutlage merged 3 commits intoedge-js:6.xfrom
bnb:bnb/add-pushToTop-and-pushToTopOnce

Conversation

@bnb
Copy link
Contributor

@bnb bnb commented Feb 13, 2026

🔗 Linked issue

#172

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds pushToTop and pushToTopOnce and adds tests for pushToTop, mirroring pushTo's tests. I've run the tests locally and it works.

I've got a situation where I have a list of events in the future and in the past, and I want the ones in the past to be in reverse chronological order but the ones in the future to be in chronological order. Rather than having to do that logic in JS, it'd be super nice to just be able to do that with Edge. pushToTop makes it super simple to set the events in the past in reverse chronological order without any JS logic around this in my app.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

bnb added 2 commits February 13, 2026 13:30
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
@bnb
Copy link
Contributor Author

bnb commented Feb 13, 2026

I'll work on a docs PR now ✅

@thetutlage
Copy link
Member

Hello @bnb

Thanks for the PR. The tests on Windows are failing, because of the newline issue. Can you please fix those?

Signed-off-by: Tierney Cyren <hello@bnb.im>
@bnb
Copy link
Contributor Author

bnb commented Feb 19, 2026

done @thetutlage

@thetutlage thetutlage merged commit a30a076 into edge-js:6.x Feb 23, 2026
4 checks passed
@thetutlage
Copy link
Member

Thanks @bnb for the PR 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants