Skip to content

build: upgrade typescript and align TD schema with W3C IRI standards #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddharthbaleja7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: upgrade typescript and align TD schema with W3C IRI standards #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"glob": "^7.1.6",
"jsonpointer": "^5.0.0",
"mocha": "^11.1.0",
"typescript": "^3.8.3",
"typescript": "^4.9.5",
"vscode-test": "^1.3.0",
"wot-thing-description": "github:w3c/wot-thing-description#bafa33e47c84bb879e1f5a102649cc3bea1ec3ca"
}
Expand Down
3 changes: 2 additions & 1 deletion schemas/TD.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"$id": "https://raw.githubusercontent.com/w3c/wot-thing-description/main/validation/td-json-schema-validation.json",
"definitions": {
"anyUri": {
"type": "string"
"type": "string",
"format": "iri-reference"
Comment on lines -9 to +10
Copy link
Member

@relu91 relu91 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation schema should be compliant with https://github.com/w3c/wot-resources/blob/main/td/v1.1/validation/td-json-schema-validation.json, which does not have the format keyword. I don't remember why it was removed, but I recall it was problematic for some reason. @egekorkan do you remember?

Copy link
Member

@egekorkan egekorkan Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was due to different implementations not validating it exactly correct. So we just say string now.

Copy link
Member

@relu91 relu91 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we should then see how vscode interpret it. Do you have some test cases we can use?

},
"description": {
"type": "string"
Expand Down