Skip to content

Conversation

@koujl
Copy link
Contributor

@koujl koujl commented Dec 30, 2025

Add empty interface methods as per HomeStore 7.1.0.

Add empty interface methods as per HomeStore 7.1.0.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase to be compatible with HomeStore 7.1.0 by adding a new interface method on_remove_member to the replication state machine. The method is currently a no-op with a TODO comment indicating future implementation is needed.

  • Added on_remove_member interface method to support HomeStore 7.1.0 API
  • Updated HomeStore dependency from version 7.0 to 7.1
  • Bumped package version to 3.0.14

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lib/homestore_backend/replication_state_machine.hpp Added on_remove_member method declaration to override the new interface from HomeStore 7.1.0
src/lib/homestore_backend/replication_state_machine.cpp Implemented empty on_remove_member method with TODO comment
conanfile.py Updated HomeStore dependency to version 7.1 and bumped package version to 3.0.14

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.83%. Comparing base (1746bcc) to head (51a9d73).
⚠️ Report is 143 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   63.15%   57.83%   -5.33%     
==========================================
  Files          32       35       +3     
  Lines        1900     4610    +2710     
  Branches      204      577     +373     
==========================================
+ Hits         1200     2666    +1466     
- Misses        600     1664    +1064     
- Partials      100      280     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koujl koujl requested a review from yuwmao December 30, 2025 06:06
@koujl koujl marked this pull request as ready for review December 30, 2025 06:06
Copy link
Contributor

@yuwmao yuwmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koujl koujl merged commit 60152e0 into eBay:main Dec 30, 2025
48 of 49 checks passed
@koujl koujl deleted the dep branch December 30, 2025 06:08
xiaoxichen pushed a commit that referenced this pull request Jan 4, 2026
Add empty interface methods as per HomeStore 7.1.0.

(cherry picked from commit 60152e0)
Besroy pushed a commit to Besroy/HomeObject that referenced this pull request Jan 4, 2026
Add empty interface methods as per HomeStore 7.1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants