-
Notifications
You must be signed in to change notification settings - Fork 17
ReplicationStateMachine: add new interfaces #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add empty interface methods as per HomeStore 7.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the codebase to be compatible with HomeStore 7.1.0 by adding a new interface method on_remove_member to the replication state machine. The method is currently a no-op with a TODO comment indicating future implementation is needed.
- Added
on_remove_memberinterface method to support HomeStore 7.1.0 API - Updated HomeStore dependency from version 7.0 to 7.1
- Bumped package version to 3.0.14
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/homestore_backend/replication_state_machine.hpp | Added on_remove_member method declaration to override the new interface from HomeStore 7.1.0 |
| src/lib/homestore_backend/replication_state_machine.cpp | Implemented empty on_remove_member method with TODO comment |
| conanfile.py | Updated HomeStore dependency to version 7.1 and bumped package version to 3.0.14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 63.15% 57.83% -5.33%
==========================================
Files 32 35 +3
Lines 1900 4610 +2710
Branches 204 577 +373
==========================================
+ Hits 1200 2666 +1466
- Misses 600 1664 +1064
- Partials 100 280 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuwmao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add empty interface methods as per HomeStore 7.1.0. (cherry picked from commit 60152e0)
Add empty interface methods as per HomeStore 7.1.0.
Add empty interface methods as per HomeStore 7.1.0.