Fix v1_ShardInfo mem layout #382
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory layout issue with the v1_ShardInfo struct by moving it outside of the #pragma pack(1) directive to ensure proper byte alignment matching the current ShardInfo struct. The version is bumped from 4.0.7 to 4.0.8 to reflect this bugfix.
- Relocated
v1_ShardInfostruct definition to before#pragma pack(1)directive - Version bumped to 4.0.8
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/homestore_backend/hs_homeobject.hpp | Moved v1_ShardInfo struct outside pragma pack(1) section to fix byte alignment |
| conanfile.py | Bumped version from 4.0.7 to 4.0.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add empty interface methods as per HomeStore 7.1.0. (cherry picked from commit 60152e0)
v1_ShardInfo should have the same byte alignment as ShardInfo struct.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4 #382 +/- ##
=====================================
Coverage ? 58.96%
=====================================
Files ? 35
Lines ? 4664
Branches ? 581
=====================================
Hits ? 2750
Misses ? 1626
Partials ? 288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
has the ut failed? |
6 participants
v1_ShardInfo should have the same byte alignment as ShardInfo struct.