Support ExtendedPostiion and Current control; Implement on_configure#101
Open
sebtiburzio wants to merge 10 commits intodynamixel-community:rollingfrom
Open
Support ExtendedPostiion and Current control; Implement on_configure#101sebtiburzio wants to merge 10 commits intodynamixel-community:rollingfrom
sebtiburzio wants to merge 10 commits intodynamixel-community:rollingfrom
Conversation
Swap Position to ExtendedPosition mode
…ntrol_mode Add current control to hardware interface
…f_to_dummy Add velocity and effort update to dummy mode
Seb/startup fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, last year I worked on a project using
dynamixel_hardware, during which I came across some problems and made some changes:on_configurecallback for initial communication with motors (instead ofon_init, to align with this diagram: https://control.ros.org/rolling/_images/hardware_interface_lifecycle.png)Couple of things to note:
ROS2_controldiagram linked above, powering the motors (enable_torque(true)) should be done in theon_activatecallback. However I found that afteron_configurecompletes the real-timeread/writecalls interfere with the dynamixel workbench functions, so I left it inon_configure. I believe similar issues are discussed here: Delayed Read Write Calls till afteron_activate()is completed #89Feel free to review the changes and see if they can be included. I am no longer working on the project (and don't have access to the hardware) but can make some updates if needed. I also noted there has been some other PRs made recently, not sure what the compatibility is with my changes.
Cheers.