Remove duplicate ignore_unknown_models option definition#316
Open
OdenTakashi wants to merge 1 commit intomainfrom
Open
Remove duplicate ignore_unknown_models option definition#316OdenTakashi wants to merge 1 commit intomainfrom
OdenTakashi wants to merge 1 commit intomainfrom
Conversation
…PTION_KEYS This option was duplicated in both FLAG_OPTIONS and OTHER_OPTIONS. Keep it in FLAG_OPTIONS as it is a boolean flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore_unknown_modelswas duplicated in bothFLAG_OPTIONSandOTHER_OPTIONS(and their corresponding key arrays) in theOptionsclass.Since it’s a boolean flag, this PR removes the redundant entries from
OTHER_OPTIONSandOTHER_OPTION_KEYS, keeping it only inFLAG_OPTIONS.No behavioral change is intended. This is a cleanup to avoid ambiguity.