drupal-graphql#1323: Add check for translation#1323
Open
artemvd wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
Open
drupal-graphql#1323: Add check for translation#1323artemvd wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
artemvd wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
Conversation
hchonov
approved these changes
Jan 11, 2023
hchonov
left a comment
There was a problem hiding this comment.
If the entity has been requested in a specific translation, that the entity does not have then I agree that the return value should be NULL since we cannot actually resolve the requested set of parameters.
|
#1388 This fixes the same issue also in EntityLoad and EntityLoadByUuid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.