[WIP] Fix ConfigurationBindingGeneratorTests failures on s390x#125227
Closed
[WIP] Fix ConfigurationBindingGeneratorTests failures on s390x#125227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoslynTestUtils.CompareLinesto accept an optional line-normalizer delegateVerifyAgainstBaselineUsingFileinGeneratorTests.Helpers.csto normalize[InterceptsLocation(1, "...")]data strings during comparison (the data is a content hash that differs on big-endian systems like s390x)Original prompt
This section details on the original issue you should resolve
<issue_title>New ConfigurationBindingGeneratorTests fail on s390x (endian issue?)</issue_title>
<issue_description>Since #104180 was merged, the following test cases are failing on s390x:
The symptom is in all cases of the type: