[cDAC] Implement GetCurrentAppDomain on IXCLRDataTask#124996
Merged
barosiak merged 8 commits intodotnet:mainfrom Mar 5, 2026
Merged
[cDAC] Implement GetCurrentAppDomain on IXCLRDataTask#124996barosiak merged 8 commits intodotnet:mainfrom
barosiak merged 8 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements IXCLRDataTask.GetCurrentAppDomain for cDAC by introducing an IXCLRDataAppDomain COM interface and a managed wrapper, plus associated signature tighten-ups and a unit test.
Changes:
- Add
IXCLRDataAppDomainCOM interface andClrDataAppDomainwrapper type. - Implement
ClrDataTask.GetCurrentAppDomainby reading the AppDomain global and returning aClrDataAppDomain. - Update several
IXCLRData*signatures to useIXCLRDataAppDomain*/IXCLRDataAppDomain**instead ofvoid*/void**, and add a test validating the new API path.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/tests/ClrDataTaskTests.cs | Adds coverage for GetCurrentAppDomain returning an AppDomain object. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.IXCLRDataProcess.cs | Updates process interface method signatures to typed IXCLRDataAppDomain*/**. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs | Introduces IXCLRDataAppDomain and updates related interface signatures, including GetCurrentAppDomain. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs | Implements GetCurrentAppDomain using cDAC globals, with DEBUG parity assert vs legacy DAC. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs | Updates module interface method signatures to typed IXCLRDataAppDomain*/**. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataFrame.cs | Adjusts GetAppDomain parameter annotation to clarify AppDomain type. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataAppDomain.cs | Adds ClrDataAppDomain COM class wrapper (currently legacy-forwarding). |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataAppDomain.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataAppDomain.cs
Show resolved
Hide resolved
barosiak
changed the title
max-charlamb
reviewed
Mar 2, 2026
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs
Outdated
Show resolved
Hide resolved
3 tasks
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataAppDomain.cs
Outdated
Show resolved
Hide resolved
max-charlamb
reviewed
Mar 3, 2026
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs
Outdated
Show resolved
Hide resolved
max-charlamb
reviewed
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataAppDomain.cs
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs
Show resolved
Hide resolved
max-charlamb
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement GetCurrentAppDomain for cDAC