Update output path for NoneSubstituteTextFiles target to include subdirectory #19176
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
reviewed
Dec 30, 2025
|
|
||
| <Target Name="NoneSubstituteTextFiles" | ||
| Inputs="@(NoneSubstituteText)" | ||
| Outputs="@(NoneSubstituteText->'$(IntermediateOutputPath)%(Filename)%(Extension)')" |
Member
There was a problem hiding this comment.
What was the issue on MacOS please?
I am not sure this target is tested much, it can pass the CI while still doing the wrong thing...
Contributor
Author
There was a problem hiding this comment.
I got Could not copy the file
For instance:
dotnet build src/fsc/fscArm64Project
Restore complete (0.6s)
FSharp.Core netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.Core/Debug/netstandard2.0/FSharp.Core.dll
FSharp.DependencyManager.Nuget netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.DependencyManager.Nuget/Debug/netstandard2.0/FSharp.DependencyManager.Nuget.dll
FSharp.Compiler.Service netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.Compiler.Service/Debug/netstandard2.0/FSharp.Compiler.Service.dll
FSharp.Build netstandard2.0 failed with 1 error(s) (2.1s)
/usr/local/share/dotnet/sdk/10.0.100/Microsoft.Common.CurrentVersion.targets(5381,5): error MSB3030: Could not copy the file "/Users/mathieu/src/fs/fsharp/artifacts/obj/FSharp.Build/Debug/netstandard2.0/PreRelease/Microsoft.FSharp.Core.NetSdk.props" because it was not found.
I'm trying with dotnet 10.0.101. Seems like I do not get the above error when using that version 😕, so there is that. I'm closing this PR since it seems that it is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix is only to be able to build on Mac OS X. Intention is to see if the build scripts are green in Ubuntu and Windows.
NO_RELEASE_NOTES