Merged
Conversation
… `regist()`, `setDstAlpha` and almost implement `draw()`
Update branch
…es to std-list and std-memory
Report for MarioClub_us (466fce5 - 16553b1)📈 Matched code: 42.44% (+0.03%, +816 bytes) ✅ 4 new matches
📈 4 improvements in unmatched functions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompilation Progress
ShadowManager::ShadowManager()ShadowManager::getShadowModelList(ShadowModel::ShadowKind)ShadowManager::regist(ShadowModel*)ShadowManager::draw(unsigned long, JGadget::TList<ShadowModel*, JGadget::TAllocator<ShadowModel*>>&)ShadowManager::calc()ShadowManager::viewCalc(unsigned long)ShadowManager::setDstAlpha()ShadowManager::~ShadowManager()Shoutouts
Huge thanks to:
@SwareJonge for helping get the
ShadowManager::ShadowManager()constructor matched and for building out more of thestd-listclass.@Cuyler36 for the help with
ShadowManager::draw(). Your tip about dereferencing iterators with(*it)was the key to getting the other functions to match!.Pikmin 2 Decomp and Super Mario Sunshine Decomp repos for their
std-listimplementation.Notes
The functions at 99% should be correct, but don't achieve 100% assembly matching due to:
The function at 57% doesn't match due to:
TListmembers.The main reasons are small quirks in our custom
std-listimplementation. While these functions aren't at 100% yet, this progress provides a solid foundation for the next person to finish the decompilation or perfect thestd-list.