fix(client): prevent panic in ContainerCreate when Config is nil #124
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents a nil-pointer panic in the SDK client’s ContainerCreate wrapper by ensuring options.Config is initialized before use, improving safety when callers omit optional fields.
Changes:
- Initialize
options.Configto a zero-valuecontainer.Configwhen it is nil inContainerCreate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initializes
options.ConfiginContainerCreatewhen it is nil to prevent a nil pointer dereference.Why is it important?
Calling
ContainerCreatewith a nilConfigpreviously caused a panic when dereferencing the value.This change ensures the SDK behaves safely when optional fields are not provided.
Related issues
N/A
How to test this PR
ContainerCreatewithout settingoptions.Configand verify it does not panic