[New Feature]: BIP-352 Sender Side Protocol#96
Open
notTanveer wants to merge 7 commits intodiybitcoinhardware:masterfrom
Open
[New Feature]: BIP-352 Sender Side Protocol#96notTanveer wants to merge 7 commits intodiybitcoinhardware:masterfrom
notTanveer wants to merge 7 commits intodiybitcoinhardware:masterfrom
Conversation
alvroble
reviewed
Aug 12, 2025
This was referenced Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the sender-side logic for BIP-352 silent payments, this lets us generate P2TR (Taproot) destination addresses.
this PR is built on top of keith's SP address generation PR #64 .
changes:
create_outputs()– main function for the BIP-352 sender flow, to generate the ouput pubkeysdecode_silent_payment_address– temp custom decoder for now, until flexible bech32 + error messages #95 gets merged ingenerate_sp_destination_address()– helper for creating P2TR addresses