Miniscript - t Wrapper Verifies if Fragment Type is V#71
Open
odudex wants to merge 1 commit intodiybitcoinhardware:masterfrom
Open
Miniscript - t Wrapper Verifies if Fragment Type is V#71odudex wants to merge 1 commit intodiybitcoinhardware:masterfrom
odudex wants to merge 1 commit intodiybitcoinhardware:masterfrom
Conversation
Collaborator
Author
|
Tests and acknowledgements from developers at @cryptoadvance (Specter-DIY) and @SeedSigner are greatly appreciated! |
Collaborator
Author
|
The commits from this pull request have now been merged into Embit's |
|
Test ACK I tested this using the following script: def miniscript_parse(input):
try:
ms = Miniscript.from_string(input, taproot=False)
ms.verify()
return True
except Exception as e:
print(e)
try:
ms = Miniscript.from_string(input, taproot=True)
ms.verify()
return True
except Exception as e:
print(e)
return False
result = miniscript_parse("ttvtvtvtvtvtvtv:after(2)")
print(result)Output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #70 by adding a verification step to ensure that a Miniscript fragment wrapped by
tis of typeV. This addition resolves an inconsistency observed in this very specific case, between Embit vs Bitcoin Core and Rust Miniscript implementations.Note: While the new code aims to standardize behavior, further input from experienced miniscripters is welcome to confirm its effectiveness and to ensure that no additional inconsistencies are introduced.
Special thanks to @brunoerg and @erickcestari for the implementation work, @qlrd for encouraging the inclusion of Embit in the fuzz setup that caught the issue, @darosior for identifying the inconsistency and pointing a fix, and @jdlcdl for the in-depth review.