feat(item): Added ability to disable Command.Item from filtering#257
Open
Jamess-Lucass wants to merge 3 commits intodip:mainfrom
Open
feat(item): Added ability to disable Command.Item from filtering#257Jamess-Lucass wants to merge 3 commits intodip:mainfrom
Jamess-Lucass wants to merge 3 commits intodip:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jamess-Lucass
changed the title
CruseCtrl
approved these changes
Dec 11, 2024
CruseCtrl
suggested changes
Dec 11, 2024
CruseCtrl
left a comment
CruseCtrl
left a comment
There was a problem hiding this comment.
I've just realised that this functionality already exists by using the forceMount prop
|
Does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.
This adds a new property to the
Command.Itemcomponent namedshouldFilter, adding the ability to specify if certain Items should be except from filtering. This is helpful when certain command items are obtained via external filtering, for example, querying some search API and you do not want the response to be further filtered.