feat: Player colours, locator bar functionality.#1084
Open
Dasciam wants to merge 8 commits intodf-mc:masterfrom
Open
feat: Player colours, locator bar functionality.#1084Dasciam wants to merge 8 commits intodf-mc:masterfrom
Dasciam wants to merge 8 commits intodf-mc:masterfrom
Conversation
Contributor
|
Maybe use the hashed player name? Or store the (randomized) color in |
Contributor
Author
a little too much imo |
DaPigGuy
reviewed
Jun 22, 2025
Dasciam
force-pushed
the
master-player-colours
branch
from
d43bdc1 to
1fc6ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential Performance Consideration
may need to remove dynamic colour changes. rapidly updating a player's colour could lead to increased traffic, as the player list entry is resent with each change
also added the toggling of locator bar