fix(helm): add liveliness and readiness probes to helm chart#143
fix(helm): add liveliness and readiness probes to helm chart#143
Conversation
b88b60f to
3d046b5
Compare
There was a problem hiding this comment.
Do we need to enable the health endpoint?
Currently, when running this inside a stac-auth-proxy pod container, it returns a 404:
>>> import httpx
>>> httpx.get("http://localhost:8000/healthz")
<Response [404 Not Found]>There was a problem hiding this comment.
The healthz path DOES include the root_path, are you using that? ie does http://localhost:8000/stac/healthz work?
|
Note Findings from a live environment test (tested in a separate internal cluster): Config used - repoURL: https://github.com/developmentseed/stac-auth-proxy.git
targetRevision: v1.0.3-rc2
path: helm/
helm:
valuesObject:
env:
UPSTREAM_URL: "http://ifrcgo-montandon-eoapi-{{ $i }}-stac:8080"
OIDC_DISCOVERY_URL: "https://goadmin-stage.ifrc.org/o/.well-known/openid-configuration"
OVERRIDE_HOST: "0"
ROOT_PATH: "/stac"
COLLECTIONS_FILTER_CLS: stac_auth_proxy.montandon_filters:CollectionsFilter
ITEMS_FILTER_CLS: stac_auth_proxy.montandon_filters:ItemsFilter
ingress:
enabled: "true"
host: "montandon-eoapi-{{ $i }}-auth-proxy.ifrc-go.dev.togglecorp.com"
className: "nginx"
tls:
enabled: "false"
replicaCount: 1
extraVolumes:
- name: filters
configMap:
name: stac-auth-proxy-filters
extraVolumeMounts:
- name: filters
mountPath: /app/src/stac_auth_proxy/montandon_filters.py
subPath: montandon_filters.py
readOnly: trueWhen setting
|
@thenav56 Am I correct that even though you're using the newer helm chart, that helm chart is still pointing at the Perhaps we should hardcode this value to the helm chart version? stac-auth-proxy/helm/values.yaml Lines 5 to 8 in 647dfa0 |
|
Hey @alukach, I was also wondering the same thing for the image tag After including this, everything is working as expected:
Would it be feasible to expose the health endpoint at It was also a bit confusing since all requests under If the chart consumer need to include that, then we should also update the documentation and note this as a breaking change in the release. |


What I'm changing
This PR attempts to integrate our existing
/healthzendpoint into K8s environmentsHow I did it
I admittedly know very little about Helm/K8s and reached for Claude Code (Opus 4.6) to complete this. Please review thoroughly
closes #140