fix(deps): update dependency pdfkit to ^0.17.0 #93
Conversation
renovate
bot
requested review from
Artmann,
jamesbhobbs and
saltenasl
as code owners
|
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pdfkit dependency in package.json is updated from ^0.13.0 to ^0.17.0. No other files or changes are present in the diff, and there are no modifications to exported or public API signatures. Pre-merge checks✅ Passed checks (3 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================
==========================
🚀 New features to boost your workflow:
|
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
5 times, most recently
from
a92069e to
4753338
Compare
saltenasl
left a comment
saltenasl
left a comment
There was a problem hiding this comment.
package-lock.json wasn't updated
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
11 times, most recently
from
d6dcf75 to
474e13b
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
3 times, most recently
from
37d71b6 to
86bc9a5
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
from
86bc9a5 to
815c838
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
3 times, most recently
from
2796a4d to
a322609
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
6 times, most recently
from
cb5fcce to
d597863
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
from
d597863 to
3fe1e4b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
2 times, most recently
from
e77df08 to
ab689d3
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
from
ab689d3 to
5577463
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
2 times, most recently
from
a7fe1da to
4915ded
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
package.json (1)
2610-2610: Update @types/pdfkit to ^0.17.0 to match runtime version.pdfkit is now at ^0.17.0, but @types/pdfkit remains at ^0.11.0—a 6-minor-version gap. Compatible type definitions (@types/pdfkit@^0.17.x) exist and should be used to catch breaking changes (like removed
PDFDocument#write()) at compile time. Update this dependency and run TypeScript type-check to surface any compatibility issues.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
3 times, most recently
from
ccffce3 to
4a2b3cb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: codecov/project
- GitHub Check: Build & Test
| "node-gyp-build": "^4.6.0", | ||
| "node-stream-zip": "^1.6.0", | ||
| "pdfkit": "^0.13.0", | ||
| "pdfkit": "^0.17.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Get the actual lines from package.json to verify the versions
sed -n '2541p;2610p' package.jsonRepository: deepnote/vscode-deepnote
Length of output: 132
🏁 Script executed:
# Also verify what's around these lines for context
sed -n '2539,2543p;2608,2612p' package.jsonRepository: deepnote/vscode-deepnote
Length of output: 421
🌐 Web query:
@types/pdfkit version 0.17.0 available npm
💡 Result:
Yes — @types/pdfkit v0.17.0 exists on npm. Install with:
npm install --save @types/[email protected]
Sources: npm package page and Snyk package info. [1][2]
References
[1] https://www.npmjs.com/package/%40types/pdfkit
[2] https://security.snyk.io/package/npm/%40types%2Fpdfkit
🌐 Web query:
pdfkit breaking changes Node.js 18 v0.15 v0.17
💡 Result:
Short summary of breaking/important changes between pdfkit v0.15 → v0.17 (Node.js 18 context):
- v0.15 (Mar 2024): dropped support for Node.js < 18 (so Node 18+ required) and removed the deprecated PDFDocument.write() method — code calling write() will break. (app.unpkg.com)
- v0.16 (Dec 2024): upgraded fontkit to 2.0 (may affect font loading/metadata behavior and font-related APIs); other internal updates (linebreak, spot colors). If you relied on fontkit internals or older font behavior, test fonts. (github.com)
- v0.17 (Apr–May 2025): added higher-level features (tables, dynamic sizing, rotatable text), fixed layout/precision and font edge-cases — these are mostly additive/bugfixes, but changes to text/layout/line-wrapping and font handling can change rendering output; test documents after upgrade. (github.com)
Recommended upgrade steps:
- Ensure runtime is Node.js 18+.
- Replace any usage of PDFDocument.write() (removed in 0.15) with the current streaming/pipe APIs (doc.pipe / doc.end / stream handling). (app.unpkg.com)
- Run full rendering tests (fonts, lists, tables, images) because fontkit 2.0 and line-wrapping/layout fixes can change output. (github.com)
If you want, I can scan your code for usages of the removed write() method and flag other likely compatibility issues — upload code or paste snippets.
Citations:
- 1: https://app.unpkg.com/pdfkit%400.15.0/files/CHANGELOG.md?utm_source=openai
- 2: https://github.com/foliojs/pdfkit/releases?utm_source=openai
- 3: https://github.com/foliojs/pdfkit/releases?utm_source=openai
- 4: https://app.unpkg.com/pdfkit%400.15.0/files/CHANGELOG.md?utm_source=openai
- 5: https://github.com/foliojs/pdfkit/releases?utm_source=openai
🏁 Script executed:
# Check if engines section has explicit Node.js version
grep -A 5 '"engines"' package.json | head -10Repository: deepnote/vscode-deepnote
Length of output: 196
🏁 Script executed:
# Verify there are actual usages of pdfkit in the codebase
fd -e ts -e js -e tsx -e jsx | xargs grep -l "pdfkit\|PDFDocument" | head -20Repository: deepnote/vscode-deepnote
Length of output: 194
🏁 Script executed:
# Check actual pdfkit usage in the code
cat src/webviews/extension-side/plotting/plotViewer.node.tsRepository: deepnote/vscode-deepnote
Length of output: 3983
🏁 Script executed:
# Check the webpack pdfkit config
cat build/webpack/pdfkit.jsRepository: deepnote/vscode-deepnote
Length of output: 566
🏁 Script executed:
# Check if there are any write() method calls that were removed in v0.15
rg "\.write\(" --type ts --type js | head -20Repository: deepnote/vscode-deepnote
Length of output: 50382
🏁 Script executed:
# Check actual pdfkit imports and usage more carefully
rg "from\s+['\"]pdfkit" --type ts --type js
rg "require\(['\"]pdfkit" --type ts --type js
rg "import.*pdfkit" --type ts --type jsRepository: deepnote/vscode-deepnote
Length of output: 342
🏁 Script executed:
# Check if there's any TypeScript compilation that would fail with mismatched types
fd package.json | xargs grep -l "typescript"Repository: deepnote/vscode-deepnote
Length of output: 123
🏁 Script executed:
# Check the actual Node.js version requirement in engines
cat package.json | grep -A 3 '"engines"'Repository: deepnote/vscode-deepnote
Length of output: 150
🏁 Script executed:
# Search for actual pdfkit method calls to see if any removed APIs are used
rg "PDFDocument|pdfkit\." --type ts -A 2 -B 2 | head -50Repository: deepnote/vscode-deepnote
Length of output: 1099
Update @types/pdfkit to match runtime version.
The runtime update to pdfkit ^0.17.0 creates a 6-minor-version gap with @types/pdfkit@^0.11.0 (line 2610). Update types to ^0.17.0 to maintain type coverage for new features. Also add "node": ">=18.0.0" to engines since pdfkit v0.15 dropped Node.js < 18 support.
🤖 Prompt for AI Agents
In package.json around lines 2541 (pdfkit) and 2610 (@types/pdfkit), the runtime
was updated to pdfkit ^0.17.0 but @types/pdfkit remains ^0.11.0; update the
@types/pdfkit entry to ^0.17.0 to match the runtime and restore accurate typing,
and add an "engines" entry requiring "node": ">=18.0.0" (or update the existing
engines field) to reflect pdfkit v0.15+ Node.js requirements; after editing,
regenerate the lockfile (yarn/npm) if applicable.
4a2b3cb to
7a43a58
Compare
renovate
bot
force-pushed
the
renovate/pdfkit-0.x
branch
from
7a43a58 to
2d03972
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^0.13.0→^0.17.0Release Notes
foliojs/pdfkit (pdfkit)
v0.17.2Compare Source
v0.17.1Compare Source
[object Object]v0.17.0Compare Source
image()without x and y coordinatesv0.16.0Compare Source
Nameproperty for set custom icon fornote()v0.15.2Compare Source
v0.15.1Compare Source
v0.15.0Compare Source
writemethodv0.14.0Compare Source
Add support for PDF/A-1b, PDF/A-1a, PDF/A-2b, PDF/A-2a, PDF/A-3b, PDF/A-3a
Update crypto-js to v4.2.0 (properly fix security issue)
Add support for EXIF orientation on JPEG images (#626 and #1353)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.