[feat] Rework reconnect logic to actually create a new connection instead of only changing the database (#746) #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for use by the command \r to call the new reconnect function. Updated help output in tests to match the change.
… for use by the command \r to call the new reconnect function. Updated help output in tests to match the change.
…emes/mycli into feat/746/rework-reconnect-command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
Reworks the reconnect logic (both the command
\rand calls from other parts of the code) to actually create a new database connection instead of simply running a command to change the database.Why:
With the existing reconnect logic, some people would get long reconnect times. Plus the logic to reconnect was more indirect as it was a result of calling another command instead of specifically creating a new connection.
Resolves #746
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.