changed localhost to default_server so that dashboard can be reached …#1
Open
vesatikkanen wants to merge 1 commit intodatboip:mainfrom
Open
changed localhost to default_server so that dashboard can be reached …#1vesatikkanen wants to merge 1 commit intodatboip:mainfrom
vesatikkanen wants to merge 1 commit intodatboip:mainfrom
Conversation
…with servername, not just with ip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with servername, not just with ip
This is a suggestion that would allow dashboard to be reached with servername. Not just with ip. I think it does not expose any security risk as it is anyway reachable already today with ip but instead make users life easier if she/he has dns pointing to raspberry pi device.
With this one if I have dns-name raspberry.myhosts.local --> [my ip address] I can open the dashboard with http://raspberry.myhosts.local:8081 which is easier than ip-address.