Updated api_get methods - try reauthenticate when 401 or 403#9
Open
milanmajchrak wants to merge 7 commits intomainfrom
Open
Updated api_get methods - try reauthenticate when 401 or 403#9milanmajchrak wants to merge 7 commits intomainfrom
api_get methods - try reauthenticate when 401 or 403#9milanmajchrak wants to merge 7 commits intomainfrom
Conversation
milanmajchrak
changed the title
api_get methods - try reauthenticate when 401 or 403
There was a problem hiding this comment.
Pull Request Overview
This PR enhances HTTP methods to retry on authentication failures and adds a new header set for plain text requests.
- Added
text_plain_request_headersfor text/plain content type - Updated
api_getto retry on 403 CSRF errors and 401 authentication errors - Mirrored retry logic in
api_post_urifor consistent behavior
Comments suppressed due to low confidence (1)
dspace_rest_client/client.py:172
- [nitpick] Update the
api_getdocstring to reflect that it now also retries on 401 (reauthentication) and 403 (CSRF token refresh).
"""
…'], since parse_json may return null and cause a TypeError.
…efreshed CSRF token is applied.
…istent logging configuration.
…date it to API Get for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with issue: https://github.com/dataquest-dev/dspace-customers/issues/253