Skip to content

Conversation

@nikhilsuri-db
Copy link
Contributor

@nikhilsuri-db nikhilsuri-db commented Dec 30, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Problem
Feature flag and telemetry endpoints were double-prepending https:// when server_hostname already included the protocol, causing https://https://host.com URLs. This broke telemetry for dbt-databricks users who configure hostnames with https:// prefix.

Solution
Added normalize_host_with_protocol() utility to handle protocol normalization
Updated feature flag and telemetry clients to use: normalize_host_with_protocol(host) + "/path"
Handles hostnames with/without protocol and trailing slashes

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

#709

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

1 similar comment
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Nikhil Suri <[email protected]>
Copy link
Contributor

@samikshya-db samikshya-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments, thanks!

Signed-off-by: Nikhil Suri <[email protected]>
Signed-off-by: Nikhil Suri <[email protected]>
"""


def normalize_host_with_protocol(host: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was rechecking this piece of code : auth_utils.py and thrift_backend - Has proper check on this already. should we use this util instead?

Also, the sea flow looks incorrect at the moment : backend/sea/utils/http_client.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants