lib/build.js: rm special formatting for storage blocks#397
lib/build.js: rm special formatting for storage blocks#397
Conversation
Removes all special formatting for storage blocks. This was interacting badly with the multiline storage conditions that are commonly used in k-uniswap. Readable formatting for storage blocks is now the responsibility of the spec author.
e342791 to
45d45c3
Compare
|
Do you have a report produced by this branch? Does the code you removed only affect how proofs are displayed in the reports? |
https://ipfs.io/ipfs/QmeZzK4VjXKd95Ab2UvD67SE6dWFuiL1qCUJxbaAwtgd8Q/
Very good question, and something I had not fully considered. The code I removed is called as part of @mhhf is this safe to remove? |
|
This breaks storage comments (see e.g. here for an example). More work needed before merging. |
Confirmed with @mhhf that this was the case out of band. |
Removes all special formatting for storage blocks in the reports.
This was interacting badly with the multiline storage conditions that are commonly used in k-uniswap. It also fixes the issue where storage blocks are indented differently to the rest of the spec. An example of both issues can be seen here
Readable formatting for storage blocks is now the responsibility of the spec author.