-
Notifications
You must be signed in to change notification settings - Fork 340
DAOS-18481 test: recovery/check_start_corner_case.yaml - Reset checker state #17449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rvers_once: False test_start_back_to_back interferes with test_two_pools_healthy. The injected fault during test_start_back_to_back (orphan container) somehow appears in the check query output during test_two_pools_healthy. It's related to the stale checker state that's not cleared between the tests. I tried to reproduce, but hasn't been successful. In the meantime, the workaround is to restart servers between the tests. The test works if executed individually, so run all the tests in check_start_corner_case.py. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: DMGCheckStartCornerCaseTest Signed-off-by: Makito Kano <[email protected]>
|
Ticket title is 'recovery/check_start_corner_case.py:DMGCheckStartCornerCaseTest.test_two_pools_healthy - Checker didn't detect inconsistent container label' |
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: DMGCheckStartCornerCaseTest Signed-off-by: Makito Kano <[email protected]>
daltonbohning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do the tests only work if executed serially? Are tests leaving the system in a bad state?
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: DMGCheckStartCornerCaseTest
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: DMGCheckStartCornerCaseTest Signed-off-by: Makito Kano <[email protected]>
I learned that the checker state doesn't get reset by simply restarting the server ( |
Thanks. I think this is a better approach than restarting the system |
test_start_back_to_back interferes with test_two_pools_healthy. The repaired fault in test_start_back_to_back (orphan container) appears in the check query output during test_two_pools_healthy. The test expects the query output to be clean at the beginning of the test, so reset the checker state by stopping (dmg check stop) and restarting with --reset (dmg check start --reset) after confirming the repair result.
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: DMGCheckStartCornerCaseTest
Steps for the author:
After all prior steps are complete: