DAOS-18402 test: Fix test_lost_majority_ps_replicas to make sure it r… #17339
+50
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoves rdb-pool from 2 ranks Currently, the algorithm removes rbd-pool only from /mnt/daos0/<pool>. rdb-pool is created in 3 out of 4 ranks randomly. Thus, if it’s not created in /mnt/daos0/<pool> of one of the nodes, the test will only remove one rdb-pool and the test will fail. Fix it so that it removes two rdb-pool. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Signed-off-by: Makito Kano <makito.kano@hpe.com>
|
Ticket title is 'CR Test Fix - recovery/pool_list_consolidation.py test_lost_majority_ps_replicas' |
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Signed-off-by: Makito Kano <makito.kano@hpe.com>
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Test-repeat: 5 Signed-off-by: Makito Kano <makito.kano@hpe.com>
Collaborator
|
Test stage Functional Hardware Medium completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17339/3/testReport/ |
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Test-repeat: 5
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Signed-off-by: Makito Kano <makito.kano@hpe.com>
shimizukko
requested review from
Nasf-Fan,
daltonbohning and
dinghwah
and removed request for
Nasf-Fan
Nasf-Fan
previously approved these changes
Jan 26, 2026
daltonbohning
requested changes
Jan 26, 2026
Comment on lines
283
to
286
| if self.server_managers[0].manager.job.using_control_metadata: | ||
| self.log.info("MD-on-SSD cluster. It will be supported later.") | ||
| # return results in PASS. | ||
| return |
Contributor
There was a problem hiding this comment.
This should be a cancel, not a pass
Suggested change
| if self.server_managers[0].manager.job.using_control_metadata: | |
| self.log.info("MD-on-SSD cluster. It will be supported later.") | |
| # return results in PASS. | |
| return | |
| if self.server_managers[0].manager.job.using_control_metadata: | |
| self.log.info("MD-on-SSD cluster. It will be supported later.") | |
| self.cancelForTicket('DAOS-18402') |
Comment on lines
302
to
303
| rdb_pool_path_0 = f"/mnt/daos0/{pool.uuid.lower()}/rdb-pool" | ||
| rdb_pool_path_1 = f"/mnt/daos1/{pool.uuid.lower()}/rdb-pool" |
Contributor
There was a problem hiding this comment.
We should get these mount paths from the params instead of hardcoding. E.g.
daos/src/tests/ftest/pool/verify_space.py
Lines 220 to 222 in d5ef326
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas
Also get the mount paths from self.server_managers[0].manager.job.yaml.engine_params Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium: false Test-tag: test_lost_majority_ps_replicas Signed-off-by: Makito Kano <makito.kano@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emoves rdb-pool from 2 ranks
Currently, the algorithm removes rbd-pool only from /mnt/daos0/. rdb-pool is created in 3 out of 4 ranks randomly. Thus, if it’s not created in
/mnt/daos0/ of one of the nodes, the test will only remove one rdb-pool and the test will fail. Fix it so that it removes two rdb-pool.
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_majority_ps_replicas
Steps for the author:
After all prior steps are complete: