Fix TypeScript type definition syntax error in dijkstraAll#222
Merged
rustedgrail merged 1 commit intodagrejs:masterfrom Feb 9, 2026
Merged
Conversation
Contributor
Author
|
Should fix #221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The dijkstraAll function had a malformed return type in index.d.ts (line 489) that caused TypeScript compilation errors.
Change
Fixed the return type signature from:
typescript): { : { [node: string]: Path } };to:
typescript): { [source: string]: { [node: string]: Path } };Impact
Resolves TypeScript errors when using the library with TypeScript projects
The return type now correctly represents that dijkstraAll returns an object mapping source nodes to their shortest path results
Aligns the type definition with the actual JavaScript implementation in lib/alg/dijkstra-all.js
Errors Fixed
TS1131: Property or signature expected
TS1005: ',' expected
TS1128: Declaration or statement expected