fix(ci): add missing dependencies to BOOST_INCLUDE_LIBRARIES #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added capy, corosio, and http to BOOST_INCLUDE_LIBRARIES to resolve CMake error: target_link_libraries failed because Boost::capy, Boost::corosio, and Boost::http were not found. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Iteration 1 added capy/corosio/http to BOOST_INCLUDE_LIBRARIES but these libraries don't exist in the boost tree. This iteration fixes both issues: 1. Install libssl-dev on Linux to satisfy OpenSSL dependency 2. Clone capy, corosio, and http from cppalliance into boost-source/libs before building These are separate cppalliance repositories that burl depends on, not standard Boost libraries. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Author
Iteration 2 - Complete FixPrevious iteration 1 issue: Added capy/corosio/http to BOOST_INCLUDE_LIBRARIES, but these libraries don't exist in the boost tree, so it had no effect. Root causes identified:
This iteration fixes both:
Changes:
This should fix all 3 failing jobs (Clang 20, GCC 15, MSVC 14.42). |
Fixed two CMake configuration issues: 1. Added asio and filesystem to BOOST_INCLUDE_LIBRARIES - http tests require asio and filesystem but they were missing - This was causing "target not found" errors for these dependencies 2. Removed Boost::corosio_openssl dependency, link OpenSSL directly - boost_corosio_openssl is not exported by corosio's CMakeLists.txt - This caused CMake export error: "target not in any export set" - Solution: Remove corosio_openssl dependency and link OpenSSL::SSL and OpenSSL::Crypto directly - This avoids the export issue while maintaining OpenSSL functionality Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Fixed CMake configuration error where Boost::filesystem target was not found. Previous attempts added filesystem to BOOST_INCLUDE_LIBRARIES but CMake warned that the library was not found in the boost tree. This is because filesystem is a standard Boost library that needs to be cloned. Solution: Clone boostorg/filesystem into boost-source/libs alongside the other cppalliance dependencies. This makes Boost::filesystem target available for the http library tests which require it. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Author
Iteration 5 - Added missing scope dependencyError Found:
Previous Attempts (Iterations 1-4):
This Fix:
Branch: slodd/fix-9c250a4 |
Fixed CMake errors where Boost::scope target was not found. Both boost_http_tests and boost_filesystem link to Boost::scope but the library was not included in BOOST_INCLUDE_LIBRARIES. Solution: Add scope to BOOST_INCLUDE_LIBRARIES. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
will-cppa
force-pushed
the
slodd/fix-9c250a4
branch
from
50ca7ff to
19721aa
Compare
Fixed incorrect include path for corosio's openssl_stream header. The header is located at boost/corosio/openssl_stream.hpp, not boost/corosio/tls/openssl_stream.hpp. This was causing compilation failures across all CI builds (Clang 20, GCC 15, MSVC 14.42). Files fixed: - include/boost/burl/session.hpp:23 - src/session.cpp:15 Reference: cppalliance/corosio uses boost/corosio/openssl_stream.hpp Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
CMake configuration was failing because boost_burl links to Boost::capy, Boost::corosio, and Boost::http, but these libraries were not included in the BOOST_INCLUDE_LIBRARIES list. This caused CMake to fail with:
Solution
Updated the CI workflow to include all required dependencies in BOOST_INCLUDE_LIBRARIES:
This ensures that when the boost-clone action scans for module dependencies, it will clone and build all required cppalliance libraries.
Testing
This fix addresses all 3 failing CI jobs:
🤖 Generated with SLODD (Iteration 1)