Guard against multiple snapshots inserted during PUT for given doc#65
Merged
nickbrowne merged 1 commit intomasterfrom Oct 23, 2025
Merged
Conversation
This change is temporary to give us an opportunity to clean up the data and fix the db constraints.
626dfdb to
18c3a84
Compare
ags
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is temporary to give us an opportunity to clean up the data and fix the db constraints.
To test:
./bin/demoserver-pgThe expected behaviour is now that step 4 returns a 404 rather than inserting an empty snapshot at version 0.
You can verify with:
On current master an empty snapshot is erroneously created when one already exists.