Add libmsgpack-c{,-static} as outputs of mspack-c-feedstock#1876
Add libmsgpack-c{,-static} as outputs of mspack-c-feedstock#1876isuruf merged 3 commits intoconda-forge:mainfrom
libmsgpack-c{,-static} as outputs of mspack-c-feedstock#1876Conversation
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
9c0bd39 to
9494f98
Compare
|
Can you please link the relevant PR here? |
|
I edited the description accordingly. |
requests/msgpack-c-static.yml
Outdated
| action: add_feedstock_output | ||
| feedstock_to_output_mapping: | ||
| msgpack-c: | ||
| - msgpack-c-static |
There was a problem hiding this comment.
And have libmsgpack-c-static when we currently have msgpack-c?
There was a problem hiding this comment.
Should we then switch msgpack-c to libmsgpack-c (like what happened to abseil and arrow-cpp)?
There was a problem hiding this comment.
That's upto @conda-forge/msgpack-c. We already have python and libpython-static, so it's not without precedent.
There was a problem hiding this comment.
I do not have any specific preference, if other conda-forge members prefer libmsgpack-c-static that is perfectly fine for me.
There was a problem hiding this comment.
The static library should start with lib. The question is whether the shared library also gets renamed (== becomes a wrapper around a new libmsgpack-c that then contains the actual shared library)
There was a problem hiding this comment.
Could we for instance introduce libmsgpack-c and have the current msgpack-c be repurposed to be an empty package depending on parts or on all the outputs of its feedstock, i.e. on libmsgpack-c (and libmsgpack-c-static and subsequent outputs in the future if any)?
There was a problem hiding this comment.
have the current
msgpack-cbe repurposed to be an empty package depending onlibmsgpack-c
That's what my (==...) was describing.
(and
libmsgpack-c-static)?
This should not be part of msgpack-c.
There was a problem hiding this comment.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
msgpack-c-static as output of mspack-c-feedstocklibmsgpack-c{,-static} as outputs of mspack-c-feedstock
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core) try to make a decision on these requests within 24 hours.What will happen when a package is marked broken?
brokenlabel to the package. Themainlabel will remain on the package and this is normal.anaconda.orgCDN picks up the new patches, you will no longer be able to install the package from themainchannel.Checklist:
I want to mark a package as broken (or not broken):
I want to archive a feedstock:
I want to request (or revoke) access to an opt-in CI resource:
I want to copy an artifact following CFEP-3:
I want to add a package output to a feedstock:
msgpack-cis distributed as a shared library with eponymous packages.This propose to add:
libmsgpack-cfor distributing the shared librarylibmsgpack-c-staticfor distributing the static library following CFEP-18's conventions.See conda-forge/msgpack-c-feedstock#50 and conda-forge/msgpack-c-feedstock#53.
Ping @conda-forge/msgpack-c.