Skip to content

Add libmsgpack-c{,-static} as outputs of mspack-c-feedstock#1876

Merged
isuruf merged 3 commits intoconda-forge:mainfrom
jjerphan:msgpack-c-static
Feb 10, 2026
Merged

Add libmsgpack-c{,-static} as outputs of mspack-c-feedstock#1876
isuruf merged 3 commits intoconda-forge:mainfrom
jjerphan:msgpack-c-static

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Feb 9, 2026

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed
  • I want to copy an artifact following CFEP-3:

    • Pinged the relevant feedstock team(s)
    • Added a reference to the original PR
    • Posted a link to the conda artifacts
    • Posted a link to the build logs
  • I want to add a package output to a feedstock:

    • Pinged the relevant feedstock team(s)
    • Added a small description of why the output is being added.

msgpack-c is distributed as a shared library with eponymous packages.

This propose to add:

  • libmsgpack-c for distributing the shared library
  • libmsgpack-c-static for distributing the static library following CFEP-18's conventions.

See conda-forge/msgpack-c-feedstock#50 and conda-forge/msgpack-c-feedstock#53.

Ping @conda-forge/msgpack-c.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan marked this pull request as ready for review February 9, 2026 12:06
@jjerphan jjerphan requested a review from a team as a code owner February 9, 2026 12:06
@xhochy
Copy link
Member

xhochy commented Feb 9, 2026

Can you please link the relevant PR here?

@jjerphan
Copy link
Member Author

jjerphan commented Feb 9, 2026

I edited the description accordingly.

action: add_feedstock_output
feedstock_to_output_mapping:
msgpack-c:
- msgpack-c-static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add lib prefix ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And have libmsgpack-c-static when we currently have msgpack-c?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'd prefer that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then switch msgpack-c to libmsgpack-c (like what happened to abseil and arrow-cpp)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's upto @conda-forge/msgpack-c. We already have python and libpython-static, so it's not without precedent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any specific preference, if other conda-forge members prefer libmsgpack-c-static that is perfectly fine for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static library should start with lib. The question is whether the shared library also gets renamed (== becomes a wrapper around a new libmsgpack-c that then contains the actual shared library)

Copy link
Member Author

@jjerphan jjerphan Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we for instance introduce libmsgpack-c and have the current msgpack-c be repurposed to be an empty package depending on parts or on all the outputs of its feedstock, i.e. on libmsgpack-c (and libmsgpack-c-static and subsequent outputs in the future if any)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the current msgpack-c be repurposed to be an empty package depending on libmsgpack-c

That's what my (==...) was describing.

(and libmsgpack-c-static)?

This should not be part of msgpack-c.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan changed the title Add msgpack-c-static as output of mspack-c-feedstock Add libmsgpack-c{,-static} as outputs of mspack-c-feedstock Feb 10, 2026
@jjerphan jjerphan requested a review from isuruf February 10, 2026 11:08
@isuruf isuruf enabled auto-merge February 10, 2026 15:36
@isuruf isuruf merged commit a4551e1 into conda-forge:main Feb 10, 2026
2 checks passed
@jjerphan jjerphan deleted the msgpack-c-static branch February 10, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants