Pull in OpenNet changes#27
Draft
JosephDuffy wants to merge 221 commits intocomposed-swift:2.0-betafrom
Draft
Conversation
Still a little hacky, more like a POC, but is overall much more flexible
…ing by cache cell section
…s on UINib(nibName:bundle:)
[SBI-519] Add Composed hotfix
…atSection # Conflicts: # Sources/ComposedUI/CollectionView/CollectionCoordinator.swift
# Conflicts: # Sources/ComposedUI/CollectionView/CollectionCoordinator.swift
The layout's `sectionInset` property is applied on a per-section basis, but the collection view's `contentInset` was not being honoured. It was also calculated using `insetBy(dx:dy:)`, which will modify the width by `-dx * 2`, which would double the expected insets. This is technically a breaking change for those relying on this behaviour, but it's a big enough bug that it should probably still be released without a major version bump. (plus not many are using the porject anyway 😬)
This API should remain private; only the results of its use should be tested
This fixes a crash when reading a header/footer during an update the previously invalidated the header/footer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is being used to diff between the OpenNet fork.
Hopefully other PRs will be merged before this (e.g. #21), which should lead to this PR having no changes and purely to ensure some of the history is not lost.