Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
…phere-cloud/oms into cleanup_bootstrapped_infra
There was a problem hiding this comment.
Pull request overview
Adds a new bootstrap-gcp cleanup CLI subcommand to delete OMS-bootstrapped GCP projects (optionally cleaning up OMS-created DNS records), aiming to remove the need for manual teardown.
Changes:
- Add
oms beta bootstrap-gcp cleanupcommand with--project-id,--force, and--skip-dns-cleanupflags. - Label newly created GCP projects with
oms-managed=trueand add client methods to verify/delete OMS-managed projects and delete OMS DNS records. - Add docs and initial test scaffolding for the cleanup functionality.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
internal/bootstrap/gcp/gcp_client.go |
Adds OMS-managed labeling on project creation and implements delete/verification/DNS cleanup client methods. |
internal/bootstrap/gcp/mocks.go |
Updates generated mock to include new GCP client manager methods. |
internal/bootstrap/gcp/gcp_client_cleanup_test.go |
Adds new tests around constants/formatting (currently not exercising new production code paths). |
cli/cmd/bootstrap_gcp_cleanup.go |
Implements the new cleanup subcommand behavior (infra file loading, verification/prompt, DNS cleanup, project deletion). |
cli/cmd/bootstrap_gcp_cleanup_test.go |
Adds tests for opts defaults and flag wiring for the new command. |
cli/cmd/bootstrap_gcp.go |
Registers the new cleanup subcommand under bootstrap-gcp. |
docs/oms-cli_beta_bootstrap-gcp_cleanup.md |
Documents the new cleanup command and flags. |
docs/oms-cli_beta_bootstrap-gcp.md |
Adds the cleanup subcommand to the bootstrap-gcp docs index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add the ability to clean up the infrastructure I created with oms beta bootstrap-gcp , so that no manual cleanup is required.
Clickup