Skip to content

feat: cleanup bootstrapped infra#185

Draft
OliverTrautvetter wants to merge 13 commits intomainfrom
cleanup_bootstrapped_infra
Draft

feat: cleanup bootstrapped infra#185
OliverTrautvetter wants to merge 13 commits intomainfrom
cleanup_bootstrapped_infra

Conversation

@OliverTrautvetter
Copy link
Member

@OliverTrautvetter OliverTrautvetter commented Feb 10, 2026

Add the ability to clean up the infrastructure I created with oms beta bootstrap-gcp , so that no manual cleanup is required.

Clickup

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new bootstrap-gcp cleanup CLI subcommand to delete OMS-bootstrapped GCP projects (optionally cleaning up OMS-created DNS records), aiming to remove the need for manual teardown.

Changes:

  • Add oms beta bootstrap-gcp cleanup command with --project-id, --force, and --skip-dns-cleanup flags.
  • Label newly created GCP projects with oms-managed=true and add client methods to verify/delete OMS-managed projects and delete OMS DNS records.
  • Add docs and initial test scaffolding for the cleanup functionality.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
internal/bootstrap/gcp/gcp_client.go Adds OMS-managed labeling on project creation and implements delete/verification/DNS cleanup client methods.
internal/bootstrap/gcp/mocks.go Updates generated mock to include new GCP client manager methods.
internal/bootstrap/gcp/gcp_client_cleanup_test.go Adds new tests around constants/formatting (currently not exercising new production code paths).
cli/cmd/bootstrap_gcp_cleanup.go Implements the new cleanup subcommand behavior (infra file loading, verification/prompt, DNS cleanup, project deletion).
cli/cmd/bootstrap_gcp_cleanup_test.go Adds tests for opts defaults and flag wiring for the new command.
cli/cmd/bootstrap_gcp.go Registers the new cleanup subcommand under bootstrap-gcp.
docs/oms-cli_beta_bootstrap-gcp_cleanup.md Documents the new cleanup command and flags.
docs/oms-cli_beta_bootstrap-gcp.md Adds the cleanup subcommand to the bootstrap-gcp docs index.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OliverTrautvetter OliverTrautvetter requested review from a team and siherrmann and removed request for a team February 11, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant