fix(mux): fix sed pattern escaping for npm tarball fallback #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes sed pattern escaping issues in the mux module's npm tarball fallback logic. When npm is unavailable, the script uses sed to parse JSON responses from the npm registry, but incorrect quote escaping (\"...\\(...\\)\") was causing the patterns to fail, resulting in 404 errors for version lookups.
Key changes:
- Fixed sed pattern escaping from
\"...\\(...\\)\"to"...\(...\)"in tarball URL extraction - Fixed sed pattern escaping in version resolution and binary path extraction
- Changed escape sequences from double-backslash to single-backslash for sed capture groups
When npm is not available, the mux module falls back to downloading the tarball directly from the npm registry. The sed patterns used to extract tarball URL, version, and bin path were double-escaping quotes, causing them to fail silently. This resulted in: - install_version="latest" or "next" failing with 404 errors - Binary path extraction failing with chmod errors Fixes the escaping from \"...\\(...\\)\" to "...\(...\)"
03kalven
force-pushed
the
fix/mux-sed-escaping
branch
from
6d3ecbe to
af5c4c3
Compare
Contributor
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
ibetitsmike
approved these changes
Jan 2, 2026
Contributor
|
@03kalven thanks for catching this, this would require a version bump in mux README you can invoke |
ibetitsmike
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When npm is not available, the mux module's sed-based fallback for extracting tarball URL, version, and bin path fails due to double-escaped quotes. This causes
install_version="latest"or"next"to 404.Fixes the escaping from
\"...\\(...\\)\"to"...\(...\)"Type of Change
Module Information
Path:
registry/coder/modules/muxNew version: N/A (patch fix)
Breaking change: [x] No
Testing & Validation
bun test)bun fmt)Related Issues
None