Skip to content

fix: fix a race condition preventing Docker metrics from being collected correctly#116

Merged
masontikhonov merged 3 commits intomasterfrom
fix-race-condition
Feb 2, 2026
Merged

fix: fix a race condition preventing Docker metrics from being collected correctly#116
masontikhonov merged 3 commits intomasterfrom
fix-race-condition

Conversation

@masontikhonov
Copy link
Contributor

@masontikhonov masontikhonov commented Jan 29, 2026

What

This fixes a race condition preventing Docker metrics from being collected correctly:

in particular, this moves init process to ./init control group at the very beginning of operation, to ensure that all subsequently started processes will stay in the above group.

Previously, because of race condition, some side processes (monitor.sh) sporadically started in <k8s-pod-container-group> group making it not possible to enable domain controllers for Docker containers.

Fixes #CR-33708

Labels

Assign the following labels to the PR:

security - to trigger image scanning in CI build

PR Comments

Add the following comments to the PR:

/e2e - to trigger E2E build

@masontikhonov masontikhonov self-assigned this Jan 29, 2026
@masontikhonov
Copy link
Contributor Author

/e2e

@masontikhonov masontikhonov requested a review from zarbis January 30, 2026 08:46
@masontikhonov
Copy link
Contributor Author

/e2e

@masontikhonov masontikhonov changed the title fix: start monitor in init cgroup to avoid race condition fix: fix a race condition preventing Docker metrics from being collected correctly Feb 2, 2026
@masontikhonov masontikhonov marked this pull request as ready for review February 2, 2026 11:19
@masontikhonov masontikhonov merged commit 7ec5ce0 into master Feb 2, 2026
6 checks passed
@masontikhonov masontikhonov deleted the fix-race-condition branch February 2, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants