Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 9, 2026

Related: #1197

This PR includes:

  • types for source sink flows
  • wal.ts - general WriteAheadLog
  • wal-trace-json.ts traceEvent specific login for a WAL
  • profiler constants to control WAL leader
  • moved trace utils into profiler

Note

This PR addresses a comment related to logging.

Warning

All filesystem operations in WAL—and indirectly in the profiler—are synchronous by design.
The eslint rules are disables over fine name pattern

Why synchronous fs is used for WAL code?

  • Profilers are side-channels, not business logic
  • Data must never be lost, reordered, or partially written
  • process.on('exit') cannot safely run async I/O
  • Sync writes guarantee ordering + durability
  • Profiler I/O volume is small → overhead is negligible
  • Crash-safety > throughput

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026

View your CI Pipeline Execution ↗ for commit bc86d08

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 27s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 30s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-18 02:39:47 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1210

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1210

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1210

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1210

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1210

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1210

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1210

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1210

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1210

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1210

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1210

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1210

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1210

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1210

commit: bc86d08

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 894a5d8 with previous commit 270b474.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 42 🔴 46 ↑ +3.5
Performance 🔴 37 🔴 34 ↓ −3.1
Code coverage 🟢 93 🟢 93 ↑ +0.2
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 1 group regressed, 👍 9 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 42 🔴 46 ↑ +3.5
Lighthouse Performance 🔴 37 🔴 34 ↓ −3.1
Code coverage Code coverage metrics 🟢 93 🟢 93 ↑ +0.2

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.0 s 🟥 7.1 s ↑ +16.9 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟨 6 undocumented classes  +0 %
JSDocs coverage Properties coverage 🟥 30 undocumented properties 🟥 37 undocumented properties ↑ +23.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.2 s ↑ +5.6 %
Lighthouse Total Blocking Time 🟥 1,890 ms 🟥 2,350 ms ↑ +24.4 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 14.1 s ↑ +8.3 %
JSDocs coverage Types coverage 🟥 268 undocumented types 🟥 258 undocumented types ↓ −3.7 %
JSDocs coverage Functions coverage 🟥 577 undocumented functions 🟥 578 undocumented functions ↑ +0.2 %
JSDocs coverage Variables coverage 🟥 268 undocumented variables 🟥 275 undocumented variables ↑ +2.6 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 15 undocumented methods ↑ +15.4 %
Code coverage Function coverage 🟩 94.4 % 🟩 94.6 % ↑ +0.3 %
Code coverage Branch coverage 🟨 89 % 🟨 89.3 % ↑ +0.3 %
Code coverage Line coverage 🟩 92.7 % 🟩 92.9 % ↑ +0.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,104 KiB 🟩 Total size was 2,092 KiB ↓ −0.6 %
Lighthouse Minimizes main-thread work 🟥 9.2 s 🟥 11.2 s ↑ +21.4 %
Lighthouse JavaScript execution time 🟥 4.3 s 🟥 5.7 s ↑ +33.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +8.3 %
Lighthouse Server Backend Latencies 🟩 1,200 ms 🟩 250 ms ↓ −79 %
Lighthouse Max Potential First Input Delay 🟥 980 ms 🟥 1,510 ms ↑ +54.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 224 KiB 🟥 Potential savings of 225 KiB ↓ −19 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.3 s ↓ −1.6 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 93 KiB 🟥 Potential savings of 93 KiB ↓ −30.4 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 500 ms ↓ −7.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↑ +3.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 20 ms ↑ +211.9 %
TypeScript Semantic errors 🟥 25 errors 🟥 26 errors ↑ +4 %

652 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Code PushUp

🥳 Code PushUp report has improved – compared current commit 894a5d8 with previous commit 270b474.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 45 🟡 51 ↑ +5.3
Code coverage 🟢 95 🟢 95 ↑ +0.4

4 other categories are unchanged.

👍 2 groups improved, 👍 9 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 45 🟡 51 ↑ +5.3
Code coverage Code coverage metrics 🟢 95 🟢 95 ↑ +0.4

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Classes coverage 🟨 3 undocumented classes 🟨 3 undocumented classes  +0 %
JSDocs coverage Properties coverage 🟥 27 undocumented properties 🟥 34 undocumented properties ↑ +25.9 %
JSDocs coverage Types coverage 🟥 66 undocumented types 🟨 56 undocumented types ↓ −15.2 %
JSDocs coverage Functions coverage 🟥 239 undocumented functions 🟥 240 undocumented functions ↑ +0.4 %
JSDocs coverage Variables coverage 🟥 49 undocumented variables 🟥 56 undocumented variables ↑ +14.3 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 15 undocumented methods ↑ +15.4 %
Code coverage Function coverage 🟩 96.2 % 🟩 96.6 % ↑ +0.4 %
Code coverage Branch coverage 🟩 91.8 % 🟩 92.2 % ↑ +0.4 %
Code coverage Line coverage 🟩 97.8 % 🟩 98 % ↑ +0.2 %

435 other audits are unchanged.


13 other projects are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review January 17, 2026 21:44
@BioPhoton BioPhoton requested a review from hanna-skryl January 17, 2026 21:44
@BioPhoton BioPhoton requested a review from matejchalk January 17, 2026 22:34
@BioPhoton BioPhoton changed the title feat(utils): add file sink classes feat(utils): add WriteAheadLog classes Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants